domain, store/tikv: enable etcd client auto sync #9575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: disksing <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #9575 +/- ##
==========================================
- Coverage 67.3% 67.29% -0.01%
==========================================
Files 376 376
Lines 78961 78963 +2
==========================================
- Hits 53144 53139 -5
- Misses 21058 21061 +3
- Partials 4759 4763 +4
Continue to review full report at Codecov.
|
This was referenced Mar 7, 2019
zz-jason
pushed a commit
that referenced
this pull request
Mar 7, 2019
zz-jason
pushed a commit
that referenced
this pull request
Mar 7, 2019
12 tasks
This was referenced May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: disksing [email protected]
What problem does this PR solve?
When all PD nodes are replaced by new PD nodes, etcd clients (used by DDL worker and safepoint syncer) in tidb will lost connection with PD cluster.
What is changed and how it works?
Enable etcd's
AutoSyncfeature so it will automatically update member list.Check List
Tests
member deleteoriginal 3 PDs.master, FALSE forauto-sync)master, TRUE forauto-sync)Note: No unit test case included, it will be more suitable to add a integration test in schrodinger later. This bug is kind urgent and the fix is straightforward so I guess we can merge it ahead.
Related changes